It’s probably OK, but I’m a bit worried that we inadvertently proxy also attributes that we shouldn’t directly expose. Also, I thin that in this way those methods are not visible with dir(...). Therefore, I would probably prefer to proxy all those we need on both classes explicitly, one by one, if that’s OK
Okay, fair enough. I should have a list of attributes which are needed and will only expose those
@ali-khosravi Apologies for the significant delay. This got sidetracked a bit by other responsibilities. I have now opened two PRs, see Add attributes to stream types needed by TextIOWrapper by ahkole · Pull Request #192 · aiidateam/disk-objectstore · GitHub and Use TextIOWrapper for opening file from repository in text mode by ahkole · Pull Request #6847 · aiidateam/aiida-core · GitHub. If someone could take a look that would be much appreciated.
1 Like